Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save event from mirrors #376

Merged
merged 5 commits into from
Oct 22, 2024
Merged

fix: save event from mirrors #376

merged 5 commits into from
Oct 22, 2024

Conversation

cameri
Copy link
Owner

@cameri cameri commented Oct 20, 2024

Description

Incoming events from mirrored relays are now saved.
It is possible to configure event limit overrides for each mirror, so that for example, mirrored events do not need to be from paid users.

Related Issue

No related issue.

Motivation and Context

Mirroring was not saving events to the database, just merely rebroadcasting it to connected clients which made mirroring less useful.

How Has This Been Tested?

  1. Manually tested

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@coveralls
Copy link
Collaborator

coveralls commented Oct 20, 2024

Pull Request Test Coverage Report for Build 11460748653

Details

  • 0 of 95 (0.0%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-2.6%) to 49.466%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/settings.ts 0 1 0.0%
src/factories/static-mirroring.worker-factory.ts 0 8 0.0%
src/app/static-mirroring-worker.ts 0 86 0.0%
Files with Coverage Reduction New Missed Lines %
src/factories/static-mirroring.worker-factory.ts 1 0.0%
src/app/static-mirroring-worker.ts 3 0.0%
Totals Coverage Status
Change from base Build 11430933844: -2.6%
Covered Lines: 1217
Relevant Lines: 2364

💛 - Coveralls

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/ws@8.5.12 None 0 21.2 kB types
npm/axios@1.7.7 network Transitive: environment, filesystem +8 2.51 MB jasonsaayman

🚮 Removed packages: npm/@types/ws@8.5.3, npm/axios@1.6.5

View full report↗︎

Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@cameri cameri merged commit 6497229 into main Oct 22, 2024
11 of 12 checks passed
@cameri cameri deleted the fix/save-events-from-mirrors branch October 22, 2024 13:09
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
# [2.1.0](v2.0.0...v2.1.0) (2024-10-23)

### Bug Fixes

* save event from mirrors ([#376](#376)) ([6497229](6497229))

### Features

* add dark theme support for static html files ([#373](#373)) ([3d1e573](3d1e573))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants