cleanup and comments

camfort · Sep 12, 2024 · 55481c9 · 55481c9
1 parent b988c25
commit 55481c9
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/Language/Fortran/Analysis/DataFlow.hs b/src/Language/Fortran/Analysis/DataFlow.hs
@@ -409,9 +409,11 @@ genConstExpMap pf = ceMap
  Nothing -> map))
  recursivelyProcessDecls stmts
 
+ -- Evaluate an expression down to a value
  getE0 :: M.Map Name Repr.FValue -> Expression (Analysis a) -> Maybe (Repr.FValue)
  getE0 pvMap e = either (const Nothing) (Just . fst) (Repr.runEvalFValuePure pvMap (Repr.evalExpr e))
 
+ -- Lookup an expression in the constants maps
  getE :: Expression (Analysis a) -> Maybe Repr.FValue
  getE = join . (flip IM.lookup ceMap <=< labelOf)
 
@@ -422,10 +424,7 @@ genConstExpMap pf = ceMap
  -- TODO constants may use other constants! but genConstExpMap needs more
  -- changes to support that
  case Repr.runEvalFValuePure pvMap (Repr.evalExpr e) of
- Left _err ->
- case e of
- ExpValue _ _ (ValVariable{}) -> Nothing
- _ -> Nothing
+ Left _err -> Nothing
  Right (a, _msgs) ->
  case e of
  ExpValue _ _ (ValVariable{}) -> Just a