Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Ord instance for all core AST types #283

Merged
merged 29 commits into from
Sep 4, 2024
Merged

Derive Ord instance for all core AST types #283

merged 29 commits into from
Sep 4, 2024
+59 −49

Conversation

raehik
Copy link
Collaborator

@raehik raehik commented Jun 15, 2024

Requested in #282 . Note that Eq was already derived.

@raehik
derive Ord instance for all core AST types
f1b7bbd 
Requested in #282 . Note that `Eq` was already derived.
@raehik raehik mentioned this pull request Jun 15, 2024
Closed
@raehik
Copy link
Collaborator Author

raehik commented Jun 15, 2024

The AST module is very large with lots of automatic deriving already taking place. Deriving Ord as well will increase compilation time. Should be kept in mind. (It'd be nice to record compilation time per module, wonder if there's a tool for that.)

@dorchard
Copy link
Member

dorchard commented Sep 4, 2024

I think this is a good idea and worth the extra time taken, which is not vast. I timed a difference of about 5s (97s vs 102s) on builds between master and this branch.

@dorchard
topological sort of dependency graph
4c72831
@dorchard
add command line argument for showing the dependency list
21f5f54
@dorchard
move some useful helper functions from Main to Utils so easier to reu…
ad0bae8 
…se elsewhere
@dorchard
add test for module graph
9a65b86
@dorchard
better error handling when there are parsing issues when building mak…
3b0b45c 
…e file graph
@dorchard
make test platform agnostic
7a120ed
@dorchard
make test platform agnostic (missed a case)
55ac84d
@dorchard
remove any duplicates
093d7ff
@dorchard
keep first occurence when removing duplicates
b5068b7
@dorchard
filepath consistency
94eb5b0
@dorchard
remove duplicates after processing to a list
9926607
@dorchard
some helpers for working with constant expression evaluator
39a7c76
@dorchard
remoev comment
69b1911
@dorchard
add missing fall through case
59e1bc4
@dorchard
more robust test
4157d22
@dorchard
feature for tagging in module maps whether names are defined loal or …
5c7737c 
…via imports
@dorchard
improve error reporting if syntax error with mod file
19f25a1
@dorchard
mod file spec test
341021c
@dorchard
add modfilespec to cabal
193dbb2
@dorchard
os agnostic test
49d9ff1
@dorchard
--version functionality
b47e91d
@dorchard
package update
d098d00
@dorchard
comment
eac05b1
@dorchard
Update README.md
61cba3a
@dorchard
add date to release
0d3d95d
@dorchard
more detail in changelog
306ec46
@dorchard
Copy link
Member

dorchard commented Sep 4, 2024

I have rebased off master

@dorchard dorchard merged commit a0c78d2 into master Sep 4, 2024
7 checks passed
@raehik raehik deleted the ast-ord-instance branch September 5, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raehik @dorchard