Localise module maps #286
Merged
Localise module maps #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(note this is rebased off #285) |
raehik
approved these changes
Sep 4, 2024
| main :: IO () | ||
| main = do | ||
| args <- getArgs | ||
| (opts, parsedArgs) <- compileArgs args | ||
| case (parsedArgs, action opts) of | ||
| (paths, ShowMyVersion) -> do | ||
| putStrLn $ "fortran-src version: " ++ showVersion |
There was a problem hiding this comment.
(We should have a release guide that instructs updating the version string shown here. I'll start a wiki page later.)
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A problem arose in CamFort with the location of declarations being misreported to the wrong file (camfort/camfort#185). It turns out this comes down to the structure of mod file analysis, where all the
used modules get their name space inserted into the module map and so it cannot be distinguished whether a variable was declared in this module or an imported one. This PR fixes this by adding information into theNameTypedata structure about whether a variable isLocalorImported. A module map can then be 'localised' withlocalisedModuleMapwhich removes from a mod map any imported declarations. This fixes the bug in CamFort.An accompanying test was added in
ModFileSpecThe
genUniqNameToFilenameMap :: ModFiles -> M.Map F.Name Stringapplies this localisation.