Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert test_theme as new style test, cleanup #11460

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Convert test_theme as new style test, cleanup #11460

merged 3 commits into from
Dec 3, 2024

Conversation

sbrunner
Copy link
Member

No description provided.

@sbrunner sbrunner force-pushed the beter-tests branch 13 times, most recently from bf09f05 to c202267 Compare October 17, 2024 08:06
@sbrunner sbrunner changed the title Beter tests Convert test_theme as new style test, cleanup Oct 17, 2024
@sbrunner sbrunner marked this pull request as ready for review October 17, 2024 11:07
@sbrunner sbrunner mentioned this pull request Nov 5, 2024
Merged
@ger-benjamin
Copy link
Member

ger-benjamin commented Dec 2, 2024 •
edited
Loading

Can you please add a ticket reference and maybe some historic/reasons of this change for our understanding and TS ?

@sbrunner
Copy link
Member Author

sbrunner commented Dec 2, 2024

@ger-benjamin you can tinesheet in: https://camptocamp.atlassian.net/browse/GSGMF-1324

ger-benjamin
ger-benjamin approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
The test_themes.py results changed a bit, I hope it's wanted, maybe check again quickly before to merge

geoportal/tests/functional/conftest.py Show resolved Hide resolved
@sbrunner sbrunner merged commit 42cb035 into master Dec 3, 2024
17 checks passed
@sbrunner sbrunner deleted the beter-tests branch December 3, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ger-benjamin ger-benjamin ger-benjamin approved these changes

@arnaud-morvan arnaud-morvan Awaiting requested review from arnaud-morvan

@llienher llienher Awaiting requested review from llienher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @ger-benjamin