Fix for new Prospector version

acceptance_tests/.prospector.yaml

@@ -1,13 +1,18 @@
----
-max-line-length: 110
+inherits:
+ - utils:base
+ - utils:no-design-checks
+ - utils:fix
+ - duplicated
 
 pylint:
  disable:
- - wrong-import-order
- - no-else-return
- - broad-except
- - unused-argument
- - missing-timeout # Default timeout set by c2cwsgiutils
+ - missing-timeout # Done by c2cwsgiutils
 
-mccabe:
+mypy:
+ run: false
+
+bandit:
+ run: false
+
+pyroma:
  run: false

acceptance_tests/acceptance/file/conftest.py

@@ -10,6 +10,7 @@ def composition(request):
  """
  Fixture that will wait that the composition is started, used for all the tests.
  """
+ del request
  for slave in ("api",):
  path = os.path.join("/config", slave)
  os.makedirs(path, exist_ok=True)
@@ -20,8 +21,9 @@ def composition(request):
 
 
 @pytest.fixture
-def app_connection(composition):
+def app_connection(composition): # pylint: disable=redefined-outer-name
  """
  Fixture that returns a connection to a running batch container.
  """
+ del composition
  return Connection(base_url="http://api_file:8080/scm/", origin="http://example.com/")

acceptance_tests/acceptance/inline/conftest.py

@@ -10,6 +10,7 @@ def composition(request):
  """
  Fixture that will wait that the composition is started, used for all the tests.
  """
+ del request
  for slave in ("api",):
  path = os.path.join("/config", slave)
  os.makedirs(path, exist_ok=True)
@@ -20,8 +21,9 @@ def composition(request):
 
 
 @pytest.fixture
-def app_connection(composition):
+def app_connection(composition): # pylint: disable=redefined-outer-name
  """
  Fixture that returns a connection to a running batch container.
  """
+ del composition
  return Connection(base_url="http://api_inline:8080/scm/", origin="http://example.com/")

acceptance_tests/acceptance/normal/conftest.py

@@ -44,6 +44,7 @@ def composition(request):
  """
  Fixture that will wait that the composition is started, used for all the tests.
  """
+ del request
  for slave in ("api", "slave", "slave-others"):
  path = os.path.join("/config", slave)
  os.makedirs(path, exist_ok=True)
@@ -55,8 +56,9 @@ def composition(request):
 
 
 @pytest.fixture
-def app_connection(composition: None):
+def app_connection(composition: None): # pylint: disable=redefined-outer-name
  """
  Fixture that returns a connection to a running batch container.
  """
+ del composition
  return Connection(base_url="http://api:8080/scm/", origin="http://example.com/")

acceptance_tests/acceptance/normal/test_workflow.py

@@ -77,7 +77,7 @@ def git_source(app_connection: Connection):
  assert not os.path.exists(os.path.join("/config", slave, "other"))
 
 
-def test_ok(app_connection, git_source):
+def test_ok(app_connection, git_source): # pylint: disable=redefined-outer-name
  time.sleep(0.1)
 
  for slave in ("api", "slave"):

acceptance_tests/pyproject.toml

@@ -8,6 +8,8 @@ authors = []
 python = ">=3.9,<3.11"
 pytest-cov = "5.0.0"
 prospector = "1.12.0"
+prospector-profile-duplicated = "1.6.0"
+prospector-profile-utils = "1.8.0"
 typing-extensions = "4.12.2"
 c2cwsgiutils = { version = "6.0.8", extras = ["standard", "test_images"] }
 requests = "2.32.3"

app/.bandit.yaml

@@ -0,0 +1,3 @@
+skips:
+ - B101 # Use of assert detected. The enclosed code will be removed when compiling to optimized byte code.
+ - B113 # Call to requests without timeout

app/.prospector.yaml

@@ -1,28 +1,13 @@
----
-strictness: veryhigh
-
-max-line-length: 110
+inherits:
+ - utils:base
+ - utils:no-design-checks
+ - utils:fix
+ - duplicated
 
 pylint:
  disable:
- - too-many-locals
- - too-many-branches
- - too-many-arguments
- - too-many-instance-attributes
- - too-many-statements
- - too-few-public-methods
- - wrong-import-order
- - no-else-return
- - broad-except
- - raising-format-tuple
- - missing-timeout # Default timeout set by c2cwsgiutils
-
-pyflakes:
- disable:
- - F401 # imported but unused, done by pylint
-
-mccabe:
- run: false
+ - missing-timeout # Done by c2cwsgiutils
 
-mypy:
- run: true
+bandit:
+ options:
+ config: .bandit.yaml