-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execution platform compatibility section for element templates #4780
base: main
Are you sure you want to change the base?
Conversation
👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉 You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still in draft
because you have additional changes you would like to make? I see this is flagged for alpha-2
, which went out last week. Do you require urgent review and release?
docs/components/modeler/desktop-modeler/element-templates/defining-templates.md
Show resolved
Hide resolved
Fixed the target release label, sorry about that! |
docs/components/modeler/desktop-modeler/element-templates/defining-templates.md
Outdated
Show resolved
Hide resolved
docs/components/modeler/desktop-modeler/element-templates/defining-templates.md
Outdated
Show resolved
Hide resolved
docs/components/modeler/desktop-modeler/element-templates/defining-templates.md
Outdated
Show resolved
Hide resolved
Thanks @barmac, suggestions applied. Backported to 8.6 and 8.5. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
a86bcfe
to
be573d3
Compare
docs/components/modeler/desktop-modeler/element-templates/defining-templates.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment still to address, but it looks good to me. @christinaausley would you say this makes sense to you? I might be biased as I was close to the implementation.
Description
Related to https://github.com/camunda/product-hub/issues/2368
With Element Templates Runtime Versions feature integrated in both Desktop and Web Modelers, we should add it to the documentation.
Element template JSON schema has a new
engines
property which can be used to specify template's compatibility with different execution platforms.When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).