Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JobResult to CompleteJobRequest for gRPC #4808

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ana-vinogradova-camunda
Copy link
Contributor

@ana-vinogradova-camunda ana-vinogradova-camunda commented Dec 23, 2024

Description

Updating gateway-service.md file CompleteJobRequest:

  • added JobResult to CompleteJobRequest
  • added JobResultCorrections to JobResult

closes camunda/camunda#26345

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

👋 🤖 🤔 Hello, @ana-vinogradova-camunda! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/apis-tools/zeebe-api/gateway-service.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@ana-vinogradova-camunda ana-vinogradova-camunda marked this pull request as ready for review December 23, 2024 15:45
@ana-vinogradova-camunda ana-vinogradova-camunda requested a review from a team December 23, 2024 15:45
Copy link
Contributor

@ce-dmelnych ce-dmelnych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ce-dmelnych ce-dmelnych added 8.7.0-alpha3 January 2024 alpha release deploy Stand up a temporary docs site with this PR labels Dec 24, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs December 24, 2024 10:27 Destroyed
Copy link
Contributor

The preview environment relating to the commit c5c8d7d has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-4808/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.7.0-alpha3 January 2024 alpha release deploy Stand up a temporary docs site with this PR
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

Update complete job rpc documentation
2 participants