Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not interrupt tests #187

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: do not interrupt tests #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/test-gha-eks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,8 @@ jobs:
timeout-minutes: 45
uses: ./.github/actions/eks-manage-cluster
id: create_eks_cluster
# Do not interrupt tests; otherwise, the Terraform state may become inconsistent.
if: always() && success()
with:
cluster-name: ${{ steps.commit_info.outputs.cluster_name }}
aws-region: ${{ env.AWS_REGION }}
Expand Down Expand Up @@ -174,7 +176,8 @@ jobs:
timeout-minutes: 20
uses: ./.github/actions/aurora-manage-cluster
id: create_aurora_cluster
if: env.CREATE_DB == 'true'
# Do not interrupt tests; otherwise, the Terraform state may become inconsistent.
if: env.CREATE_DB == 'true' && always() && success()
with:
cluster-name: ${{ steps.commit_info.outputs.cluster_name }}
username: ${{ steps.commit_info.outputs.db_username }}
Expand All @@ -194,7 +197,8 @@ jobs:
- name: Deploy OpenSearch Domain
uses: ./.github/actions/opensearch-manage-cluster
id: deploy_opensearch_domain
if: env.CREATE_OPENSEARCH == 'true'
# Do not interrupt tests; otherwise, the Terraform state may become inconsistent.
if: env.CREATE_OPENSEARCH == 'true' && always() && success()
with:
domain-name: ${{ steps.commit_info.outputs.cluster_name }}-opensearch
aws-region: ${{ env.AWS_REGION }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ jobs:

- name: Launch test
timeout-minutes: 125
# Do not interrupt tests; otherwise, the Terraform state may become inconsistent.
if: always() && success()
run: |
export TESTS_CLUSTER_ID="${{ needs.configure-tests.outputs.cluster_id }}"
export TESTS_CLUSTER_REGION="${{ env.AWS_REGION }}"
Expand Down
Loading