feat(rest): Add support for storing GraphQL/REST Connector's response as a document #3746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnBgood
commented
Dec 4, 2024
| @@ -97,4 +97,8 @@ public void deleteDocument(CamundaDocumentReference reference) { | |||
| public void clear() { | |||
| documents.clear(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
found it helpful for test purposes, and this is the InMemory store not a production one, I guess it's ok
johnBgood
commented
Dec 4, 2024
| * The connector is executed in the context of the cloud function. This is where the | ||
| * HttpCommonRequest will be executed. | ||
| */ | ||
| record SaaSCloudFunctionSideEnvironment(boolean storeResponseSelected) |
There was a problem hiding this comment.
maybe the Environment part of the name is redundant, let me know
johnBgood
commented
Dec 4, 2024
| * Environment variable to check if the current execution is running in a Google Cloud Function. | ||
| */ | ||
| private static final String CLOUD_FUNCTION_MARKER_VARIABLE = | ||
| "CAMUNDA_CONNECTOR_HTTP_BLOCK_URL_GCP_META_DATA_INTERNAL"; |
There was a problem hiding this comment.
we could create another env variable dedicated to this purpose, wdyt?
johnBgood
changed the title
johnBgood
force-pushed
the
787-file-upload-download-support-for-the-rest-connector
branch
from
14ff3f9 to
9f899d6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
connectors/http/http-base/src/test/java/io/camunda/connector/http/base/HttpServiceTest.java
Dismissed
Show dismissed
Hide dismissed
connectors/http/http-base/src/test/java/io/camunda/connector/http/base/HttpServiceTest.java
Dismissed
Show dismissed
Hide dismissed
johnBgood
force-pushed
the
787-file-upload-download-support-for-the-rest-connector
branch
2 times, most recently
from
638134a to
b9fc1e7
Compare
johnBgood
force-pushed
the
787-file-upload-download-support-for-the-rest-connector
branch
from
1df27e3 to
a8c2e84
Compare
sbuettner
reviewed
Dec 17, 2024
| @@ -45,7 +46,7 @@ public static class BuilderFinalStep { | |||
| private String documentId; | |||
| private String storeId; | |||
| private String contentType; | |||
| private String fileName; | |||
| private String fileName = UUID.randomUUID().toString(); | |||
There was a problem hiding this comment.
Lets let the client decide on the filename and not do it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
documentfields in the response + in the process variablesRelated issues
https://github.com/camunda/team-connectors/issues/787
#3734
Checklist
no milestonelabel.