Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: GH-620 centralized composite action and configuration to test GHA runner labels against self-hosted runners #300

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Kerruba
Copy link

@Kerruba Kerruba commented Nov 21, 2024

Related to: camunda/team-infrastructure#620.

Create a composite action to validate and lint repository workflows using actionlint.
The composite action configuration includes self-hosted runner labels supported by infrastructure team and available in Camunda

Some possible questions:

Why using all the actionlint checks instead of using only the runners-label check
💬 From what I've seen in actionlint usage documentation, there's no way to limit the checks to only specific one

What's the rationale behind the way actionlint is downloaded? Why not use asdf or similar approached?
💬 That's the way actionlint documentation suggest to download actionlint executable

Why using a composite action instead of a reusable workflow?
💬 I was thinking of using a reusable workflow at the very beginning to solve the chicken-egg issue of running the composite action on an invalid runner. Reusable workflow would solve this indeed, but having a reusable workflow only for a single job (actionlint) seemed to me a bit too much. Also, most (if not all) the shared workflows in this repository are composite actions. Therefore I've decided to use a composite action right now, leaving the door open for a future improvement

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Kerruba Kerruba force-pushed the gh-620-centralized-infracheck-workflow branch from b5c29a5 to 8b43e78 Compare November 21, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants