address mypy errors

cancervariants · Oct 26, 2023 · 8876692 · 8876692
1 parent 47fe22d
commit 8876692
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/therapy/query.py b/therapy/query.py
@@ -386,9 +386,11 @@ def _add_merged_meta(self, response: NormalizationService) -> NormalizationServi
         """
         sources_meta = {}
         therapeutic_agent = response.therapeutic_agent
-        sources = [response.normalized_id.split(":")[0]]
-        if therapeutic_agent.mappings:
-            sources += [m.coding.system for m in therapeutic_agent.mappings]
+        sources = [response.normalized_id.split(":")[0]]  # type: ignore
+        if therapeutic_agent.mappings:  # type: ignore
+            sources += [
+                m.coding.system for m in therapeutic_agent.mappings  # type: ignore
+            ]
 
         for src in sources:
             try:
@@ -476,11 +478,11 @@ def _add_therapeutic_agent(
                         )
                     ]
                 else:
-                    mappings = None
+                    mappings = []
                 ind_disease_obj = core_models.Disease(
                     id=indication.disease_id,
                     label=indication.disease_label,
-                    mappings=mappings
+                    mappings=mappings or None
                 )
 
                 if indication.supplemental_info:

diff --git a/therapy/schemas.py b/therapy/schemas.py
@@ -355,7 +355,7 @@ class ServiceMeta(BaseModel):
     """Metadata regarding the therapy-normalization service."""
 
     name: Literal["thera-py"] = "thera-py"
-    version: Literal[__version__] = __version__
+    version: Literal[__version__] = __version__  # type: ignore
     response_datetime: datetime
     url: Literal[
         "https://github.com/cancervariants/therapy-normalization"
@@ -395,7 +395,9 @@ class UnmergedNormalizationService(BaseNormalizationService):
     attributes.
     """
 
-    normalized_concept_id: Optional[constr(pattern=r"^\w[^:]*:.+$")] = None  # noqa: F722, E501
+    normalized_concept_id: Optional[  # type: ignore
+        constr(pattern=r"^\w[^:]*:.+$")  # noqa: F722
+    ] = None
     source_matches: Dict[SourceName, MatchesNormalized]
 
     model_config = ConfigDict(