-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use vrs 2.0-alpha models in /normalize #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsstevenson
previously approved these changes
Oct 26, 2023
korikuzma
added
priority:low
Low priority
and removed
priority:high
High priority
labels
Oct 26, 2023
A few changes: In
to
and change
to
and in
to
I'm testing with imports of HemOnc and Wikidata and they appear to work with the changes above (minus a separate HemOnc error which I've made a new issue for). |
jsstevenson
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #363
Going to wait to open until Disease Normalization PR is merged. But would still like your review @jsstevenson now . This PR is very similar to the gene/disease PRs.Notes:
pydantic
to v2ga4gh.vrsatile.pydantic
and switch to usega4gh.vrs
for core/vrs 2-alpha models*
TherapeuticDescriptor
-->TherapeuticAgent
disease-normalizer
versionresponse_model_exclude_none=True
in FastAPI responseQueryHandler
, method_add_vod
renamed to_add_therapeutic_agent