Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error in debug logging of cloud-what #3363

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

m-horky
Copy link
Contributor

@m-horky m-horky commented Dec 19, 2023

The requests.PreparedRequest may not have any .body attribute set. This happens when unit tests are run, for example. In that case the test would crash.

This is a follow-up to #3361

@cnsnyder cnsnyder requested review from a team and ptoscano and removed request for a team December 19, 2023 13:13
Copy link

github-actions bot commented Dec 19, 2023

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
cloud_what
   _base_provider.py2064876%42, 144, 151, 169, 187, 199, 207–208, 219–221, 228–229, 250, 287–289, 304–306, 312–313, 318, 353, 362–363, 365–367, 369–371, 373, 384–385, 387–388, 390–391, 393, 412, 417, 450, 459, 478–479, 483, 499
TOTAL18185459374% 

Tests Skipped Failures Errors Time
2640 14 💤 0 ❌ 0 🔥 46.248s ⏱️

The `requests.PreparedRequest` may not have any `.body` attribute set.
This happens when unit tests are run, for example. In that case the test
would crash.
@ptoscano ptoscano force-pushed the mhorky/connection-debug-fix branch from 6ec0759 to 52e95f8 Compare January 2, 2024 10:15
@ptoscano ptoscano merged commit 30c861f into main Jan 2, 2024
16 checks passed
@ptoscano ptoscano deleted the mhorky/connection-debug-fix branch January 2, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants