feat(machines): Add new IP address field to Edit Physical form MAASENG-3453 #5511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
ndv99
changed the title
ndv99
changed the title
amylily1011
approved these changes
Aug 20, 2024
| import { useFormikContext } from "formik"; | ||
| import { isIPv4 } from "is-ip"; | ||
| import { useSelector } from "react-redux"; | ||
| import * as Yup from "yup"; |
There was a problem hiding this comment.
It looks like the code imports Yup here for validation, but there is no validation schema provided below. (I might be missing something.)
There was a problem hiding this comment.
Ah - you'll need to expand line 40 in that file to see it, it is there though!
amylily1011
added
Review: QA +1
Review: Code +1
and removed
Review: QA needed
Review: Code needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
PrefixedIpInputto the "Edit Physical" formQA steps
Fixes
Resolves MAASENG-3453
Screenshots
Before
After