Mount redesign #3698
Open
Mount redesign #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## default-mount-target-dart-ffi #3698 +/- ##
================================================================
Coverage ? 88.93%
================================================================
Files ? 254
Lines ? 14302
Branches ? 0
================================================================
Hits ? 12720
Misses ? 1582
Partials ? 0 ☔ View full report in Codecov by Sentry. |
andrei-toterman
force-pushed
the
default-mount-target-dart-ffi
branch
from
ad871c5
to
a6d6dac
Compare
andrei-toterman
force-pushed
the
mount-redesign
branch
from
0b14c4b
to
b4b4bed
Compare
andrei-toterman
force-pushed
the
default-mount-target-dart-ffi
branch
from
a6d6dac
to
2bcf6d0
Compare
andrei-toterman
force-pushed
the
mount-redesign
branch
from
b4b4bed
to
4f2908f
Compare
andrei-toterman
force-pushed
the
default-mount-target-dart-ffi
branch
from
2bcf6d0
to
7529af8
Compare
andrei-toterman
force-pushed
the
mount-redesign
branch
from
4f2908f
to
9648897
Compare
andrei-toterman
force-pushed
the
default-mount-target-dart-ffi
branch
from
7529af8
to
82eec21
Compare
andrei-toterman
force-pushed
the
mount-redesign
branch
from
9648897
to
f9d9341
Compare
andrei-toterman
force-pushed
the
default-mount-target-dart-ffi
branch
from
82eec21
to
bd96a13
Compare
andrei-toterman
force-pushed
the
mount-redesign
branch
2 times, most recently
from
864ba49
to
f6fa82e
Compare
levkropp
requested changes
Oct 8, 2024
levkropp
approved these changes
Oct 11, 2024
andrei-toterman
force-pushed
the
default-mount-target-dart-ffi
branch
from
bd96a13
to
4a72529
Compare
andrei-toterman
force-pushed
the
mount-redesign
branch
from
932bcc8
to
b1ce55f
Compare
andrei-toterman
force-pushed
the
mount-redesign
branch
from
b1ce55f
to
2b46fba
Compare
andrei-toterman
force-pushed
the
default-mount-target-dart-ffi
branch
from
4a72529
to
d9c986f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the redesign of the mounting interface, as well as some cosmetic changes to the pages that use the mounting interface, namely the launch panel and the individual instance page.
See https://warthogs.atlassian.net/browse/MULTI-894 and https://warthogs.atlassian.net/browse/MULTI-895 for the details of the changes.
There was also some refactoring of adjacent code that is not necessarily mount-related (e.g. splitting some files into multiple files), so that the modification and addition of the mount code is easier