Sgmoore/add core24 support #5092

ScarlettGatelyMoore · 2024-10-04T08:56:03Z

[ x] Have you followed the guidelines for contributing?
[x ] Have you signed the CLA?
[x ] Have you successfully run tox run -m lint?
[x ] Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

didn't make it into my local repo.

…pport

codecov · 2024-10-04T09:13:57Z

Codecov Report

Attention: Patch coverage is 95.12195% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.71%. Comparing base (654871d) to head (8510f5f).
Report is 667 commits behind head on main.

Files with missing lines	Patch %	Lines
snapcraft/extensions/kde_neon.py	96.36%	2 Missing ⚠️
snapcraft/extensions/kde_neon_6.py	92.59%	2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (654871d) and HEAD (8510f5f). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (654871d) HEAD (8510f5f)

2 1

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5092      +/-   ##
==========================================
- Coverage   94.88%   89.71%   -5.17%     
==========================================
  Files         658      341     -317     
  Lines       55189    22649   -32540     
==========================================
- Hits        52364    20320   -32044     
+ Misses       2825     2329     -496

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ScarlettGatelyMoore · 2024-10-07T13:43:04Z

@mr-cal @sergiusens Please help with this security scan. I don't know how to fix it. Thanks

mr-cal · 2024-10-07T13:52:22Z

@mr-cal @sergiusens Please help with this security scan. I don't know how to fix it. Thanks

Hi @ScarlettGatelyMoore, you can ignore the security scan failures for now, it is a problem between github and trivy that @lengau has been investigating.

This is the error I'm referring to:

2024-10-07T13:30:16Z	FATAL	Fatal error	init error: DB error: failed to download vulnerability DB: database download error: OCI repository error: 1 error occurred:
	* GET https://ghcr.io/v2/aquasecurity/trivy-db/manifests/2: TOOMANYREQUESTS: retry-after: 426.143µs, allowed: 44000/minute

lengau · 2024-10-08T13:08:19Z

@mr-cal @sergiusens I believe the security scan is fixed with this, but I haven't properly tested it yet so I don't have a PR. ITMT we can just re-run them.

lengau

This LGTM so far, but I'd like to snap an app with it before I give explicit approval just in case I come across any quirks we might want to document.

lengau · 2024-10-08T13:17:44Z

snapcraft/extensions/kde_neon_6.py

+                        "default-provider": "mesa-2404",
+                    },
+                }
+                gpu_layouts = {


This isn't really about this PR, but comparing this to the gnome extension we've got a lot of overlap. I wonder whether it would be worth creating an abstract DesktopExtension where this sort of general stuff could live, so we can share more common work?

@mr-cal @sergiusens @kenvandine what do you think?

Things that overlap and could just be extended for each desktop include

plugs

GPU plugs

GPU layouts

Some base themes

I'm happy to do the work for that, but I only want to do it if I'm actually making things better :-)

pack.

snapcraft/extensions/kde_neon_6.py

This reverts commit f1dc881.

…ime content" This reverts commit c43fe13.

ScarlettGatelyMoore · 2024-11-27T09:50:30Z

I can't seem to sort this one out - google:ubuntu-22.04-64:tests/spread/core22/linters/library

@lengau @mr-cal @sergiusens

mr-cal · 2024-11-27T14:27:29Z

There's nothing useful in the log. I'll run it again and see if it fails again.

ScarlettGatelyMoore · 2024-12-02T15:13:25Z

There's nothing useful in the log. I'll run it again and see if it fails again.

It looks like last rebase fixed it.

mr-cal · 2024-12-09T15:33:50Z

@ScarlettGatelyMoore - is this ready for review?

ScarlettGatelyMoore · 2024-12-09T15:58:14Z

Yes... please.

ScarlettGatelyMoore · 2024-12-16T14:01:19Z

@ScarlettGatelyMoore - is this ready for review?
Hi! Sorry, just released from hospital. Just rebased and hopefully we can get this approved soon? Thanks!

mr-cal · 2024-12-16T15:17:16Z

I will review this week

mr-cal

Looks good, just some minor feedback.

snapcraft/extensions/kde_neon.py

tests/spread/extensions/kde-neon/task.yaml

lengau

LGTM! I installed this branch and built a Keysmith snap off it, which I intend to make a merge request for as soon as this lands on stable.

extensions/desktop/command-chain-kde/run

tests/spread/extensions/kde-neon/task.yaml

Improve error. Co-authored-by: Alex Lowe <alex.lowe@canonical.com>

ScarlettGatelyMoore · 2024-12-18T12:31:38Z

Done! Thanks!

ScarlettGatelyMoore · 2024-12-19T11:31:59Z

Well it's broken now after @lengau error change. I am confused as to why. I can't find where the call is coming from and our snaps have worked just fine. I have added the file it is demanding to the content snap, but it will be awhile before it will be done. This makes zero sense to me.

ScarlettGatelyMoore · 2024-12-21T13:56:34Z

please re-trigger tests @mr-cal @lengau

This reverts commit 8363306.

ScarlettGatelyMoore and others added 12 commits June 28, 2024 03:03

kde-neon-6: Fix long standing theming issues with Qt snaps.

95645cf

Merge branch 'main' into sgmoore/Fix_QT_snaps_theming

7a3f71e

Merge branch 'canonical:main' into sgmoore/Fix_QT_snaps_theming

54ac164

Split kde themes into our own common themes snap including gtk themes.

cef25a0

Merge branch 'canonical:main' into sgmoore/Fix_QT_snaps_theming

669bdb9

Add back commit bc4ba44 that somehow

bb29b70

didn't make it into my local repo.

Merge branch 'main' into sgmoore/Fix_QT_snaps_theming

919cedb

Merge branch 'main' into sgmoore/Fix_QT_snaps_theming

b608c1f

Merge branch 'main' into sgmoore/Fix_QT_snaps_theming

e03a21a

kde_neon_6: Add core24 support / Fix themeing connects.

514c6f5

Merge remote-tracking branch 'origin/main' into sgmoore/add_core24_su…

7bea58e

…pport

kde-neon-6: Fix tests.

7ef9f48

ScarlettGatelyMoore added 3 commits October 4, 2024 06:49

Merge branch 'main' into sgmoore/add_core24_support

8411dd6

Remove uneeded staticmethod.

fbf909f

Merge branch 'canonical:main' into sgmoore/add_core24_support

969518b

Merge branch 'main' into sgmoore/add_core24_support

7647205

Merge branch 'canonical:main' into sgmoore/add_core24_support

b6cf912

lengau reviewed Oct 8, 2024

View reviewed changes

ScarlettGatelyMoore added 3 commits October 8, 2024 23:23

Merge branch 'main' into sgmoore/add_core24_support

97d9802

Ensure we are using our desktop integration bundled with runtime content

c43fe13

pack.

Fix black linter.

f1dc881

soumyaDghosh reviewed Oct 10, 2024

View reviewed changes

snapcraft/extensions/kde_neon_6.py Outdated Show resolved Hide resolved

soumyaDghosh reviewed Oct 10, 2024

View reviewed changes

snapcraft/extensions/kde_neon_6.py Outdated Show resolved Hide resolved

ScarlettGatelyMoore added 3 commits October 10, 2024 07:10

Merge branch 'canonical:main' into sgmoore/add_core24_support

81acafd

Revert "Fix black linter."

b38db8e

This reverts commit f1dc881.

Revert "Ensure we are using our desktop integration bundled with runt…

696ef98

…ime content" This reverts commit c43fe13.

ScarlettGatelyMoore added 3 commits November 25, 2024 02:51

Merge branch 'main' into sgmoore/add_core24_support

3c90d77

Add libproxy to LD_LIBRARY_PATH as it can no longer find it's own libs.

f7c209e

Remove whitespace.

b68df90

Merge branch 'main' into sgmoore/add_core24_support

9d31175

Merge branch 'main' into sgmoore/add_core24_support

58ffcac

mr-cal requested a review from lengau December 17, 2024 15:44

mr-cal reviewed Dec 17, 2024

View reviewed changes

snapcraft/extensions/kde_neon.py Show resolved Hide resolved

snapcraft/extensions/kde_neon.py Outdated Show resolved Hide resolved

tests/spread/extensions/kde-neon/task.yaml Outdated Show resolved Hide resolved

lengau approved these changes Dec 17, 2024

View reviewed changes

extensions/desktop/command-chain-kde/run Show resolved Hide resolved

tests/spread/extensions/kde-neon/task.yaml Outdated Show resolved Hide resolved

ScarlettGatelyMoore and others added 5 commits December 18, 2024 05:12

docstring descriptions of new variables.

9c82a3d

update docstring for assumes version.

7bae3c3

Add spred test for kde-neon-6/core24.

b00db13

Update extensions/desktop/command-chain-kde/run

8363306

Improve error. Co-authored-by: Alex Lowe <alex.lowe@canonical.com>

Merge branch 'main' into sgmoore/add_core24_support

a511a82

ScarlettGatelyMoore added 3 commits December 18, 2024 07:36

Add docstring for qt5 vars too. Fix command chain tests.

0ef092e

Undo command chain change..

1ee8f81

Update kde command chain.

3e69ae8

Merge branch 'main' into sgmoore/add_core24_support

0f22827

ScarlettGatelyMoore added 3 commits December 23, 2024 06:49

Merge branch 'main' into sgmoore/add_core24_support

df75448

Call desktop hook.

8a2bce7

Revert "Update extensions/desktop/command-chain-kde/run "

8510f5f

This reverts commit 8363306.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sgmoore/add core24 support #5092

Sgmoore/add core24 support #5092

ScarlettGatelyMoore commented Oct 4, 2024

codecov bot commented Oct 4, 2024 •

edited

Loading

ScarlettGatelyMoore commented Oct 7, 2024

mr-cal commented Oct 7, 2024

lengau commented Oct 8, 2024

lengau left a comment

lengau Oct 8, 2024

ScarlettGatelyMoore commented Nov 27, 2024

mr-cal commented Nov 27, 2024

ScarlettGatelyMoore commented Dec 2, 2024

mr-cal commented Dec 9, 2024

ScarlettGatelyMoore commented Dec 9, 2024

ScarlettGatelyMoore commented Dec 16, 2024

mr-cal commented Dec 16, 2024

mr-cal left a comment

lengau left a comment

ScarlettGatelyMoore commented Dec 18, 2024

ScarlettGatelyMoore commented Dec 19, 2024

ScarlettGatelyMoore commented Dec 21, 2024

Sgmoore/add core24 support #5092

Are you sure you want to change the base?

Sgmoore/add core24 support #5092

Conversation

ScarlettGatelyMoore commented Oct 4, 2024

codecov bot commented Oct 4, 2024 • edited Loading

Codecov Report

ScarlettGatelyMoore commented Oct 7, 2024

mr-cal commented Oct 7, 2024

lengau commented Oct 8, 2024

lengau left a comment

Choose a reason for hiding this comment

lengau Oct 8, 2024

Choose a reason for hiding this comment

ScarlettGatelyMoore commented Nov 27, 2024

mr-cal commented Nov 27, 2024

ScarlettGatelyMoore commented Dec 2, 2024

mr-cal commented Dec 9, 2024

ScarlettGatelyMoore commented Dec 9, 2024

ScarlettGatelyMoore commented Dec 16, 2024

mr-cal commented Dec 16, 2024

mr-cal left a comment

Choose a reason for hiding this comment

lengau left a comment

Choose a reason for hiding this comment

ScarlettGatelyMoore commented Dec 18, 2024

ScarlettGatelyMoore commented Dec 19, 2024

ScarlettGatelyMoore commented Dec 21, 2024

codecov bot commented Oct 4, 2024 •

edited

Loading