chore: add a CODEOWNERS file #5177
Conversation
Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
There was a problem hiding this comment.
I think adding codeowners outside our team is a great idea, here's what I can think of:
extensions/ros*, snapcraft/extensions/*ros*, snapcraft/parts/plugins/[colcon_plugin,_ros]- @artivisextensions/desktop/[kde*,common], snapcraft/extensions/kde*- @ScarlettGatelyMooresnapcraft/extensions/env_injector.py- @farshidtz or @locnnilsnapcraft/parts/plugins/matter_sdk_plugin- @farshidtzsnapcraft/parts/plugins/kernel_plugin, snapcraft_legacy/plugins/v2/*kernel*- @kubikoextensions/desktop/[command-chain,common,gnome,src], snapcraft/extensions/gnome- I'm not sure, possibly @seb128?
Note to anyone I tagged - the implication of the CODEOWNERS file is that if someone submits a PR to change the code in one of these files, you will be notified and requested to review.
| /docs/ @medubelko @mr-cal | ||
|
|
||
| # Finally, all CODEOWNERS changes need to be approved by The Man, Himself. | ||
| /.github/CODEOWNERS @sergiusens |
There was a problem hiding this comment.
You can give env_injector to me:
| /.github/CODEOWNERS @sergiusens | |
| /.github/CODEOWNERS @sergiusens | |
| /snapcraft/extensions/env_injector.py @locnnil @farshidtz | |
| /tests/spread/extensions/env-injector @locnnil @farshidtz |
Edit: I'm letting also @farshidtz taking care of this because he promised to be nice. 😄
May I request that, additionally to myself, you add @canonical/robotics (or alternatively |
That's actually a great idea, so someone else from the team can respond when an individual isn't available. It should also make the maintenance of the code owner list easier, in case the team members change. If possible please use @canonical/industrial as code owner for the matter and env-injector plugins. |
This file follows the standard Starcraft ownership model, but there might be more nuances for snapcraft. For example, should there be additional owners on things like the gnome extension?
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)