s390x: ensure chreipl is called before unmounting /target #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ZFS, we recently introduced a call to $(umount --recursive /target) slighly before shutting down or rebooting. Unfortunately, on s390x, we also had a very late call to chreipl to make the firmware boot from the installed system. The call to chreipl reads data from /target/boot, and it fails if the filesystem is no longer mounted. Fixed by calling chreipl earlier in the installation, during the postinst phase rather than after the user clicks "reboot". Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
|
Tested on z/VM, After reboot, the system booted the newly installed system. Furthermore, the logs on the target system show the successful call to |
mwhudson
approved these changes
Sep 19, 2023
| @@ -666,6 +667,17 @@ async def install(self, *, context): | |||
| ) | |||
| raise | |||
|
|
|||
| async def platform_postinstall(self): | |||
| """Run architecture specific commands/quirks""" | |||
There was a problem hiding this comment.
genuine question do we want to use a context here to inform the user this is happening?
There was a problem hiding this comment.
I think that would be a good idea. At least for platforms that don't just noop.
|
Merging - Olivier, please consider the context change for a follow-on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ZFS, we recently introduced a call to
umount --recursive /targetslighly before shutting down or rebooting. Unfortunately, on s390x, we also had a very late call tochreiplto make the firmware boot from the installed system.The call to
chreiplreads data from/target/boot, and it fails if the filesystem is no longer mounted.Fixed by calling
chreiplearlier in the installation, during the postinst phase rather than after the user clicks "reboot".LP: #2029479