Fix crash when switching sources having different variations #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
When the source changes, the available variations should change as well. If we keep the old variations in the FilesystemController._variations_info dictionary, we end up with a crash later in the install. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
|
I just tested the fix in the desktop installer - and I confirm the crash does not occur anymore |
dbungert
reviewed
Oct 10, 2023
| @@ -404,6 +404,7 @@ def disallowed_encryption(msg): | |||
| return info | |||
|
|
|||
| async def _examine_systems(self): | |||
| self._variation_info.clear() | |||
There was a problem hiding this comment.
do we also need to reset self._info?
There was a problem hiding this comment.
That's a fair point. self._info is set through a call to set_info_for_capability - which only happens after a POST to /storage/guided (or /storage). I would need a build a test-case for that as well.
There was a problem hiding this comment.
OK, not blocking for this
dbungert
approved these changes
Oct 10, 2023
|
Oops. I'm sorry all this ended up so complicated :( |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the source changes, the available variations should change as well. If we keep the old variations in the FilesystemController._variations_info dictionary, we end up with a crash later in the install, showing something like: