-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes invalid links reported by linkcheck in docs #1838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the link checker doesn't follow redirects? Good to know!
@Chris-Peterson444 It does. The man pages at manpages.ubuntu.com don't use HTTP redirects. AFAICT, they're JS redirects, which aren't recognized by most agents. See:
|
Scratch that. They pbbly use nginx rewrite. |
6a80345
to
7347195
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like you to explore linkcheck_allowed_redirects (if it works, I assume it won't) and linkcheck_ignore for the manpage problem. Or if that's not an option, we might as well bump the series to mantic at this point.
Thanks for the suggestion. Looking into it. |
7347195
to
6829f30
Compare
Introduced the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy for the linkcheck test. Please update series, RTD doesn't like extlinks at the moment, and rebase to drop the merge commit. Thanks!
d8c7672
to
c7c8f50
Compare
(Introduced the extlinks extension for handling manpage links.)
b50ef8c
to
162a2e9
Compare
Yeah, silly me :) I'm still learning how RTD and Sphinx works. I added the 'extlinks' extension where I shouldn't. I fixed it, and now it builds fine with the extension. |
Fixes FR-5664
See $subj.