-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebrand /ceph/consulting #14473
base: feature-rebrand-ceph
Are you sure you want to change the base?
Rebrand /ceph/consulting #14473
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-rebrand-ceph #14473 +/- ##
=======================================================
Coverage ? 69.64%
=======================================================
Files ? 120
Lines ? 3419
Branches ? 1178
=======================================================
Hits ? 2381
Misses ? 1013
Partials ? 25
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, left some minor comments and questions. Great work overall!
<div class="row"> | ||
<div class="col-2"> | ||
<p class="p-text--small-caps"> | ||
What's included: <sup><a href="#os-footnote">*</a></sup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what #os-footnote stands for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It links to the footnote at the bottom of the card
8676b39
to
37b0243
Compare
37b0243
to
1a478c1
Compare
Done
QA
Issue / Card
Fixes WD-16345
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines