Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand /ceph/consulting #14473

Open
wants to merge 5 commits into
base: feature-rebrand-ceph
Choose a base branch
from

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Nov 12, 2024

Done

  • Rebrand /ceph/consulting
  • Update shared sections in Ceph bubble for resources and users

QA

Issue / Card

Fixes WD-16345

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature-rebrand-ceph@8bad2f2). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             feature-rebrand-ceph   #14473   +/-   ##
=======================================================
  Coverage                        ?   69.64%           
=======================================================
  Files                           ?      120           
  Lines                           ?     3419           
  Branches                        ?     1178           
=======================================================
  Hits                            ?     2381           
  Misses                          ?     1013           
  Partials                        ?       25           
---- 🚨 Try these New Features:

@immortalcodes
Copy link
Member

I checked the old page and I think a line is missing here
image
image

Copy link
Member

@immortalcodes immortalcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, left some minor comments and questions. Great work overall!

templates/ceph/consulting.html Outdated Show resolved Hide resolved
templates/ceph/consulting.html Outdated Show resolved Hide resolved
templates/ceph/consulting.html Outdated Show resolved Hide resolved
templates/ceph/consulting.html Outdated Show resolved Hide resolved
<div class="row">
<div class="col-2">
<p class="p-text--small-caps">
What's included: <sup><a href="#os-footnote">*</a></sup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what #os-footnote stands for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It links to the footnote at the bottom of the card

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants