Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authentication issue #54

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix authentication issue #54

merged 1 commit into from
Jan 23, 2024

Conversation

cp-sneha-s
Copy link
Collaborator

Purpose

  • Fix: The user stuck on the home screen with constant loading

Summary of Changes

  • Get Firebase authentication status of a user before redirecting to the screen

cp-pratik-k
cp-pratik-k reviewed Jan 23, 2024
View reviewed changes
lib/data/provider/user_state.dart
_userState = UserState.spaceJoined;
} else if (_userPreference.getAccount() != null) {
_userState = UserState.authenticated;
if (_firebaseAuth.currentUser != null){
Copy link
Collaborator

@cp-pratik-k cp-pratik-k Jan 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if when firebaseAuth.currentUser is null?

@cp-pratik-k cp-pratik-k self-requested a review January 23, 2024 08:43
@jimmy0251 jimmy0251 merged commit 079376a into main Jan 23, 2024
1 check passed
@jimmy0251 jimmy0251 deleted the fix-authentication-issue branch January 23, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cp-pratik-k cp-pratik-k cp-pratik-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cp-sneha-s @cp-pratik-k @jimmy0251