Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite to path expression, if alias for relative is already used in subselect to avoid sql error #125

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

sjvans
Copy link
Contributor

@sjvans sjvans commented Nov 4, 2024

supersedes #116

@schiwekM
Copy link

schiwekM commented Nov 8, 2024

Is the shortcut from #116 maybe still something which could be added? I think most data subjects only have one key and building the subselect directly targeting the data subject would be cheaper to execute and faster in cases where the data subject is multiple relations away.

@sjvans sjvans marked this pull request as ready for review November 27, 2024 09:46
@sjvans
Copy link
Contributor Author

sjvans commented Nov 27, 2024

Is the shortcut from #116 maybe still something which could be added? I think most data subjects only have one key and building the subselect directly targeting the data subject would be cheaper to execute and faster in cases where the data subject is multiple relations away.

sorry, but not in the short term. i'd rather go in the direction of #123, but not a priority right now.

@sjvans sjvans merged commit a45f829 into main Nov 27, 2024
6 checks passed
@sjvans sjvans deleted the fix-unknown branch November 27, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants