fix: properly support default, cds.on.insert and cds.on.update for UPSERT queries
#425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelBrucksch
requested review from
BobdenOs,
patricebender,
danjoa,
johannes-vogel and
stewsk
as code owners
SamuelBrucksch
changed the title
danjoa
previously requested changes
Jan 29, 2024
There was a problem hiding this comment.
Let's review that in one of our next syncs please ...
These are a lot of code changes all over the place, just to add support for defaults?
Particularly dislike, that we now seem to do quoting everywhere?
P.S. After the big cleanup we need extra discipline to keep it clean ;)
BobdenOs
changed the title
BobdenOs
requested review from
gregorwolf,
sebastianesch and
vobu
as code owners
Merged
|
Hey @BobdenOs , is there any ETA on this PR? 💯 |
johannes-vogel
approved these changes
Oct 22, 2024
BobdenOs
changed the title
default, cds.on.insert and cds.on.update for UPSERT queries
BobdenOs
approved these changes
Oct 22, 2024
Merged
johannes-vogel
added a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.14.1</summary> ## [1.14.1](db-service-v1.14.0...db-service-v1.14.1) (2024-10-28) ### Fixed * deep delete for views ([#496](#496)) ([82154ef](82154ef)) * properly support `default`, `cds.on.insert` and `cds.on.update` for `UPSERT` queries ([#425](#425)) ([338e9f5](338e9f5)) * SELECT cds.hana.BINARY ([#870](#870)) ([33c3ebe](33c3ebe)) </details> <details><summary>sqlite: 1.7.5</summary> ## [1.7.5](sqlite-v1.7.4...sqlite-v1.7.5) (2024-10-28) ### Fixed * properly support `default`, `cds.on.insert` and `cds.on.update` for `UPSERT` queries ([#425](#425)) ([338e9f5](338e9f5)) </details> <details><summary>postgres: 1.10.2</summary> ## [1.10.2](postgres-v1.10.1...postgres-v1.10.2) (2024-10-28) ### Fixed * properly support `default`, `cds.on.insert` and `cds.on.update` for `UPSERT` queries ([#425](#425)) ([338e9f5](338e9f5)) </details> <details><summary>hana: 1.4.0</summary> ## [1.4.0](hana-v1.3.2...hana-v1.4.0) (2024-10-28) ### Added * Improve procedure metadata lookup logic ([#862](#862)) ([da629d9](da629d9)) ### Fixed * enable `cesu8` by default for `hdb` driver and encode entries streams ([#868](#868)) ([d85d7e6](d85d7e6)) * Include `binary` type with `varbinary` type in `hana-client` ([#871](#871)) ([f4d7caf](f4d7caf)) * nested functions in comparisons ([#861](#861)) ([f3fd254](f3fd254)) * properly support `default`, `cds.on.insert` and `cds.on.update` for `UPSERT` queries ([#425](#425)) ([338e9f5](338e9f5)) * SELECT cds.hana.BINARY ([#870](#870)) ([33c3ebe](33c3ebe)) * Throw error if rows in limit is missing for expand, same as in limit() ([#858](#858)) ([641c3b9](641c3b9)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Johannes Vogel <31311694+johannes-vogel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the
UPSERTimplementation of all the database services. resulting in 2 helper functions in each database service that allow for defining the database specific JSON extraction logic and the database specificundefinedcheck. With these special cases covered it is possible to generateINSERTandUPSERTstatements that correctly applydefault,@cds.on.insertand@cds.on.updatevalues. Which currently only apply to@cap-js/hanaand is a big blocker for most use cases ofUPSERTand the@sap/cds/common.cdsuse the@cds.on.insertannotations. Which with the currentUPSERTimplementation could possibly benullwhich should be impossible as every entry in the database has to have been inserted once.