fix: reject all path expressions w/o foreign keys #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a draft enabled model:
```
namespace my;
entity Books {
key ID : Integer;
title : String;
stock : Integer;
author : Association to Authors;
}
entity Authors {
key ID : Integer;
name : String;
alive : Boolean;
}
service CatalogService {
@odata.draft.enabled
@readonly entity Books as projection on my.Books;
@readonly entity Authors as projection on my.Authors;
}
```
`my.Books` will have a field:
```
"IsActiveEntity": {
"type": "cds.Boolean",
"key": true,
"default": {
"val": true
},
"@UI.Hidden": true
},
```
which is marked as virtual by the lean draft implementation.
This virtual key must not be part of the primary key matching
which is done for a path expression in a `UPDATE.where`:
https://github.com/cap-js/cds-dbs/blob/982b8b796da4b577c5641039d2036816209c0437/db-service/test/cqn4sql/UPDATE.test.js#L73-L97
TODO:
- [] test this
reject all path expressions which navigate along a managed association which does not provide foreign keys. In this case, we can't construct join conditions, where exists subqueries or correlated subqueries for expands.
patricebender
requested review from
danjoa,
johannes-vogel,
stewsk,
BobdenOs and
sjvans
as code owners
stewsk
reviewed
Sep 13, 2024
stewsk
approved these changes
Sep 25, 2024
| title : String; | ||
| stock : Integer; | ||
| author : Association to Authors; | ||
| authorWithExplicitForeignKey: Association to Authors { ID }; |
There was a problem hiding this comment.
If there was a calculated element
authorName : author.name;
Would selecting authorName in a query have to be handled separately?
There was a problem hiding this comment.
good point, I added this as a test case → does not need to be handled separately :)
Merged
johannes-vogel
pushed a commit
that referenced
this pull request
Oct 1, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.13.0</summary> ## [1.13.0](db-service-v1.12.1...db-service-v1.13.0) (2024-10-01) ### Added * Add quoted mode support ([#681](#681)) ([43c7a6c](43c7a6c)) ### Fixed * **deep-queries:** properly return insert result ([#803](#803)) ([8d800e2](8d800e2)) * dont use virtual key for `UPDATE … where (<key>) in <subquery>` ([#800](#800)) ([d25af70](d25af70)) * reject all path expressions w/o foreign keys ([#806](#806)) ([cd271a8](cd271a8)) </details> <details><summary>hana: 1.3.0</summary> ## [1.3.0](hana-v1.2.0...hana-v1.3.0) (2024-10-01) ### Added * Add quoted mode support ([#681](#681)) ([43c7a6c](43c7a6c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reject all path expressions which navigate along a managed association which does not provide foreign keys. In this case, we can't construct join conditions, where exists subqueries or correlated subqueries for expands.