fix: allocate a new Buffer for each chunk of a Blob stream when using hana-client #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
requested review from
danjoa,
johannes-vogel,
stewsk,
patricebender,
sjvans and
David-Kunz
as code owners
johannes-vogel
approved these changes
Oct 16, 2024
Merged
johannes-vogel
pushed a commit
that referenced
this pull request
Oct 21, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>hana: 1.3.2</summary> ## [1.3.2](hana-v1.3.1...hana-v1.3.2) (2024-10-21) ### Fixed * Adjust Decimal formatter to always render a whole number ([#853](#853)) ([027d717](027d717)) * allocate a new Buffer for each chunk of a Blob stream when using hana-client ([#846](#846)) ([ec75b50](ec75b50)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original optimization was put into place to prevent allocating to much memory when streaming large data from HANA. This change relies on the memory management capabilities of
nodejsto detect when aBufferis no longer being referenced. Making this code identical in all scenarios where the optimization was working as intended, but will allow scenarios where theBufferis kept for an extended period of time to not be changed with following reads.fixes: #788