Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to CDS 8 and optimize the logic for finding the root entity. #105

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Sv7enNowitzki
Copy link
Collaborator

@Sv7enNowitzki Sv7enNowitzki commented Aug 13, 2024

Fix:

  1. The serviceEntity is not captured in the ChangeLog table in some cases.
  2. When modeling an inline entity, the keys attribute in the Changes table recorded the unexpected association and parent ID.
  3. When reqData is undefined, special handling is required.
  4. When running test cases in CDS 8, the request failed with a status code of 404.
  5. In CDS 8, for auto-exposed Compositions, all direct CRUD requests are rejected in non-draft cases. When executing test cases, an error with the message ENTITY_IS_AUTOEXPOSED occurs because the ChangeView falls under the aforementioned circumstances.
  6. In CDS 8, CAP does not support queries for draft-enabled entities on the application service. When running test cases, the related test cases failed and contained the error message: SqliteError: NOT NULL constraint failed: AdminService_Books_drafts.DraftAdministrativeData_DraftUUID.
  7. In CDS 8, the cds.transaction will be deprecated and needs to be replaced with req.event.
  8. req._params and req.context are not official APIs and need to be replaced with official properties to ensure code stability.

Optimize:

  1. Implement a method to analyze entities, determine their structure, add a flag to indicate whether it is a root entity, and when the entity is a child entity, record information about its parent entity.

Copy link
Contributor

@nkaputnik nkaputnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this work, this looks quite promising and comprehensive

@nkaputnik nkaputnik merged commit 9661d6f into main Aug 19, 2024
3 checks passed
@nkaputnik nkaputnik deleted the cds8-adaptation branch August 19, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants