Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format date properties #125

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Format date properties #125

wants to merge 4 commits into from

Conversation

schiwekM
Copy link
Contributor

@schiwekM schiwekM commented Oct 7, 2024

Hi colleagues,

currently if a cds.Date property is modified it is shown as '2022-12-01' in the change log. This is not really user friendly and thus this PR adds date formatting so the dates show up as they would in UI5, e.g. '01 Dec 2022'

BR,
Marten

@schiwekM schiwekM requested a review from nkaputnik October 7, 2024 06:19
@schiwekM
Copy link
Contributor Author

@Sv7enNowitzki could this one be considered too? Would be great to have it for improved UX, because business users at not to used to the ISO format for dates.

@nkaputnik
Copy link
Contributor

Hello Marten, I have to reject this PR.
Change log Dates are indeed meant to be technical, and require to be e.g. sortable and searchable.
The use cases we encounter frequently are, that the change logs aren't even shown with the built-in UI facet, but rather in a separate, dedicated change-log UI. Since the format is statically determined at write-time, and not dynamically when reading, localizing what was written is not a good idea, especially when searching for a specific date in the logs by users in different locales.

@schiwekM
Copy link
Contributor Author

Hi Nik, I just checked again and the logic is only run in an after READ handler on ChangeView so on DB it is as intended still in ISO format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants