Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coemstics #22

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Coemstics #22

merged 2 commits into from
Oct 12, 2023

Conversation

mnkiefer
Copy link
Contributor

@mnkiefer mnkiefer commented Oct 12, 2023 •
edited
Loading

  • Fix i18n label: ChangeHistoryList-> ChangeHistory
  • Remove following note (as this is no longer the case):
  // IMPORTANT: If we omit field 'entity' below, objectID and parentObjetId are empty in the UI
  // REVISIT: Find out and eliminate the reason for that
  • Fix column widths so as not to cut off the first one as seen here:
Screenshot 2023-10-12 at 14 41 28

@mnkiefer
Update index.cds
fe57644 
- Remove Note:
```
  // IMPORTANT: If we omit field 'entity' below, objectID and parentObjetId are empty in the UI
    // REVISIT: Find out and eliminate the reason for that
```
@mnkiefer
Add missing comma
1a53904
@mnkiefer mnkiefer requested a review from sjvans October 12, 2023 12:46
@mnkiefer mnkiefer merged commit 92e496f into main Oct 12, 2023
3 checks passed
@mnkiefer mnkiefer deleted the cleanup branch October 12, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjvans sjvans Awaiting requested review from sjvans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mnkiefer