Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve cds.auth #392

Merged
merged 11 commits into from
Sep 4, 2023
Merged

improve cds.auth #392

merged 11 commits into from
Sep 4, 2023

Conversation

sjvans
Copy link
Contributor

@sjvans sjvans commented Aug 31, 2023

No description provided.

node.js/authentication.md Outdated Show resolved Hide resolved
node.js/authentication.md Outdated Show resolved Hide resolved
@sjvans sjvans marked this pull request as ready for review August 31, 2023 12:16
node.js/authentication.md Outdated Show resolved Hide resolved
node.js/authentication.md Outdated Show resolved Hide resolved
Copy link
Contributor

@danjoa danjoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 + see inline comments below

node.js/authentication.md Outdated Show resolved Hide resolved
node.js/authentication.md Outdated Show resolved Hide resolved
@sjvans sjvans enabled auto-merge (squash) September 4, 2023 11:58
@sjvans sjvans disabled auto-merge September 4, 2023 12:02
@sjvans sjvans merged commit 9cfeb38 into main Sep 4, 2023
4 checks passed
@sjvans sjvans deleted the improved-cds-auth branch September 4, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants