Speed up bundle install when gems did not change
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This project lacks automated tests, which makes reviewing and approving PRs somewhat difficult. Please make sure that your contribution has not broken backwards compatibility or introduced any risky changes. Generated by 🚫 Danger |
Bundler has the `--local` flag that disables expensive network requests. Makes sense to try it first. If gems are not yet installed on the server, it will fail. In this case, the "normal" command will be executed. It will download new gems.
|
I have discovered #95 and realised that this PR is not necessary. I have collected some timings from the commands. The project has 264 gems in total. All commands ran on the bundle directory that already contained all required gems (from previous installs). bundle install --path /path/to/project/shared/bundle --without development test --deployment --quiet # 30.127s
bundle install --path /path/to/project/shared/bundle --without development test --deployment --quiet --local # 4.540s
bundle check --path /path/to/project/shared/bundle # 1.794sSo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone!
Bundler has the
--localflag that disables expensive network requests. Makes sense to try it first.If gems are not yet installed on the server, it will fail. In this case, the "normal" command will be executed. It will download new gems.
The drawback of this solution is that the local command is not printed. Doesn't look like a big deal though. The "normal" command is printed. Please do let me know if it's better to print the original as well, and how, because I don't have a clear idea.
I have tested this change on a real project. Deployment time dropped by ~20 seconds. The server is in Moscow.