edgetest sparkfix #269
Merged
edgetest sparkfix #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdosani
requested review from
ak-gupta,
jdawang,
gladysteh99 and
NikhilJArora
as code owners
jdawang
approved these changes
Feb 21, 2024
Merged
rhaffar
pushed a commit
to rhaffar/datacompy
that referenced
this pull request
Sep 12, 2024
* moving to conda dep * edgetest action python version * edgetest action python version * adding in cloudpickle * adding in cloudpickle * [TEMP] changing branch * [TEMP] changing branch * reverting some changes * DEBUG * DEBUG * DEBUG * DEBUG * DEBUG * DEBUG * DEBUG * DEBUG * DEBUG * DEBUG * DEBUG * DEBUG * finally..it works...RIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
After a bunch of tinkering, I kind of just changed course here and drop the
edgetestaction. It was picking up the wrong env (which I'm too tired to dig into at the moment). I got it working by embedding the logic directly into the action.pythonBumped up versions to 3.10actions/checkoutis nowv3peter-evans/create-pull-requestfor automating PR.edgetestis back and working now: https://github.com/capitalone/datacompy/pull/268/files