Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Feature/views transition api #67

Closed

Conversation

Kilian
Copy link
Contributor

@Kilian Kilian commented Feb 8, 2023

Initial work for #52

Things to do:

  • Fallback to old behavior when views transition api is not available
  • Animate in the dialog wrapper/container itself without fading out the image inside it
  • closing animation
  • works on all pages
  • Prevent scrolling back to top
  • Prevent page being scrollable when dialog is opened
  • Staggered animation
  • Works with multiple images on a page (requires unique names in CSS to support this)

strangely, it works fine on e.g. http://localhost:8080/tips/en/see-json-responses/ but breaks on http://localhost:8080/tips/en/disable-abusive-debugger-statement/

@captainbrosset
Copy link
Owner

This is super exciting! Thanks for this initial work. Let me know when you think this is ready for review/merging.

@Kilian
Copy link
Contributor Author

Kilian commented Feb 10, 2023

Using it is quite rough still, but I'm getting there. Lots of visual artifacts.

@Kilian Kilian marked this pull request as draft February 10, 2023 12:28
@Kilian
Copy link
Contributor Author

Kilian commented Feb 10, 2023

Found the draft button!

@Kilian Kilian force-pushed the feature/views-transition-api branch from eb148c9 to 87000f6 Compare March 21, 2023 16:01
@Kilian
Copy link
Contributor Author

Kilian commented Mar 21, 2023

I'm gonna close this out. As cool as it is, there's too many rough edges that I don't understand why they work the way they do. Maybe we can revisit it in the future.

@Kilian Kilian closed this Mar 21, 2023
@captainbrosset
Copy link
Owner

Ok, sounds good. Thanks, Kilian, for taking the time to investigate, and use this as a way to report feedback about the API too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants