Skip to content

Commit

Permalink
Add additional comments to describe how s3 credentials can be specifi…
Browse files Browse the repository at this point in the history
…ed for image building jobs
  • Loading branch information
deadlycoconuts committed Dec 24, 2024
1 parent 848c995 commit 66839b4
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion api/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -459,8 +459,11 @@ type MlflowConfig struct {
// Note that the Kaniko image builder needs to be configured correctly to have the necessary credentials to download
// the artifacts from the blob storage tool depending on the artifact service type selected (gcs/s3). For gcs, the
// credentials can be provided via a k8s service account or a secret but for s3, the credentials can be provided via
// additional arguments in the config KanikoAdditionalArgs e.g.
// 1) additional arguments in the config KanikoAdditionalArgs e.g.
// --build-arg=[AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY/AWS_DEFAULT_REGION/AWS_ENDPOINT_URL]=xxx
// OR
// 2) additional arguments in the config KanikoAPIServerEnvVars, which will pass the specified environment variables
// PRESENT within the Merlin API server's container to the image builder as build arguments
ArtifactServiceType string `validate:"required,oneof=nop gcs s3"`
}

Expand Down

0 comments on commit 66839b4

Please sign in to comment.