Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Image Building Process #547

Merged
merged 43 commits into from
Mar 20, 2024
Merged

Rework Image Building Process #547

merged 43 commits into from
Mar 20, 2024

Conversation

ariefrahmansyah
Copy link
Contributor

@ariefrahmansyah ariefrahmansyah commented Mar 5, 2024 •
edited
Loading

Description

This PR reworks how Merlin simplifies the model image building by merging the user and Merlin dependencies so the Conda environment installation (creation) only happens once.

Modifications

  1. Publish merlin-pyfunc-server to PyPI
  2. Add merlin-pyfunc-server onto the user's conda.yaml via merlin-sdk and pyfunc-server/docker/base.Dockerfile
  3. Refactor pyfunc-server/docker/base.Dockerfile and pyfunc-server/docker/Dockerfile

Tests

  • Processing conda environment from merlin sdk
  • Deploy pyfunc server model to gojek dev environment
  • Create prediction job to gojek dev environment

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes

Future Improvements

These tasks will be picked up on separate PRs:

  • Update README.md for batch-predictor and pyfunc-server
  • Update run pyfunc server locally

@ariefrahmansyah ariefrahmansyah added the enhancement New feature or request label Mar 5, 2024
@ariefrahmansyah ariefrahmansyah self-assigned this Mar 5, 2024
@ariefrahmansyah ariefrahmansyah changed the title [EXPERIMENTAL] Rework Image Building Rework Image Building Process Mar 13, 2024
@ariefrahmansyah
Copy link
Contributor Author

Ready for review @leonlnj @deadlycoconuts @khorshuheng

leonlnj
leonlnj approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@leonlnj leonlnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ariefrahmansyah ariefrahmansyah merged commit 06f121c into main Mar 20, 2024
34 checks passed
@ariefrahmansyah ariefrahmansyah deleted the exp-rework-image-building branch March 20, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadlycoconuts deadlycoconuts deadlycoconuts left review comments

@khorshuheng khorshuheng khorshuheng left review comments

@leonlnj leonlnj leonlnj approved these changes

Assignees

@ariefrahmansyah ariefrahmansyah

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ariefrahmansyah @leonlnj @khorshuheng @deadlycoconuts