Create topic before publishing prediction log #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariefrahmansyah
approved these changes
Mar 22, 2024
khorshuheng
force-pushed
the
auto-create-topic
branch
from
3ac9afd to
ff802f0
Compare
khorshuheng
force-pushed
the
auto-create-topic
branch
from
ff802f0 to
2f29522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if the Kafka brokers do not support auto topic creation, PyfuncV3Model will fail to publish the prediction log due to missing topic. This PR add a step to ensure that the topic is present prior to publishing the message.
Modifications
Create topic during publisher initizliation.
Tests
Checklist
Release Notes