Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen merlin-sdk deps in components #558

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

ariefrahmansyah
Copy link
Contributor

Description

Update merlin's components dependencies to merlin-sdk with less strict version constraints. So we don't need to update it once we release the merlin-sdk.

Modifications

Update merlin-pyfunc-server and merlin-batch-job's requirements.txt to have merlin-sdk<0.42.0

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes


@ariefrahmansyah ariefrahmansyah added the enhancement New feature or request label Mar 26, 2024
@ariefrahmansyah ariefrahmansyah self-assigned this Mar 26, 2024
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong, but whenever we don't have to update this anymore even when releasing newer versions of Merlin (e.g. v0.43, v0.44, ...)?

@ariefrahmansyah
Copy link
Contributor Author

Correct me if I'm wrong, but whenever we don't have to update this anymore even when releasing newer versions of Merlin (e.g. v0.43, v0.44, ...)?

Yes, as we've discussed offline, we start with pinning the merlin-sdk version first to maintain forward compatibility. The merlin-pyfunc-server and merlin-batch-job may have new versions in the future, but for some time, they will still use merlin-sdk<0.42.0

@deadlycoconuts
Copy link
Contributor

Okay, thanks a lot for clarifying the release process! :D

@ariefrahmansyah ariefrahmansyah merged commit 27b5507 into main Mar 26, 2024
34 of 35 checks passed
@ariefrahmansyah ariefrahmansyah deleted the components-merlin-sdk-deps branch March 26, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants