Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Fix unmovable replica count in TransformerStep #566

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

deadlycoconuts
Copy link
Contributor

Description

This PR fixes a tiny bug whereby the replica count slider of a transformer is not movable. This happens because the value environment in the ResourcesPanel component is undefined, and this happens because the TransformerStep component that uses it doesn't pass any value for environment as a prop, unlike ModelStep. As such, this PR modifies TransformerStep to pass the environment_name (the environment selected by the user in ModelStep) as a prop to ResourcesPanel.

Screenshot 2024-04-02 at 6 57 13 PM

Modifications

  • ui/src/pages/version/components/forms/steps/TransformerStep.js - Make TransformerStep pass environment_name to ResourcesPanel.

Tests

Checklist

  • Added PR label
  • [] Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes

NONE

@deadlycoconuts deadlycoconuts added the bug Something isn't working label Apr 2, 2024
@deadlycoconuts deadlycoconuts self-assigned this Apr 2, 2024
Copy link
Contributor

@ariefrahmansyah ariefrahmansyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for a quick fix, @deadlycoconuts!

@deadlycoconuts
Copy link
Contributor Author

Wow thanks for the quick review! :D

@leonlnj leonlnj merged commit c1039ae into main Apr 3, 2024
35 checks passed
@leonlnj leonlnj deleted the fix_ui_bug_transformer_replica_slider_stuck branch April 3, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants