feat: add default sampling rate to mlobs logger #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorshuheng
force-pushed
the
add-default-sampling-rate
branch
from
1b52605 to
1b637dd
Compare
khorshuheng
force-pushed
the
add-default-sampling-rate
branch
from
1b637dd to
252d6ae
Compare
khorshuheng
force-pushed
the
add-default-sampling-rate
branch
from
252d6ae to
c2b9834
Compare
tiopramayudi
approved these changes
Apr 16, 2024
khorshuheng
added a commit
that referenced
this pull request
Apr 16, 2024
<!-- Thanks for sending a pull request! Here are some tips for you: 1. Run unit tests and ensure that they are passing 2. If your change introduces any API changes, make sure to update the e2e tests 3. Make sure documentation is updated for your PR! --> # Description <!-- Briefly describe the motivation for the change. Please include illustrations where appropriate. --> As of now, the mlobs logger logs every single message sent to the logger. As there is no good way at the moment to use different logger configuration for different model, tentatively, we will be adding a default sampling rate that will apply to all models that enable mlobs logger. # Modifications <!-- Summarize the key code changes. --> Add a 2% sampling rate to mlobs sink. # Tests <!-- Besides the existing / updated automated tests, what specific scenarios should be tested? Consider the backward compatibility of the changes, whether corner cases are covered, etc. Please describe the tests and check the ones that have been completed. Eg: - [x] Deploying new and existing standard models - [ ] Deploying PyFunc models --> # Checklist - [ ] Added PR label - [ ] Added unit test, integration, and/or e2e tests - [ ] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduces API changes # Release Notes <!-- Does this PR introduce a user-facing change? If no, just write "NONE" in the release-note block below. If yes, a release note is required. Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information about release notes, see kubernetes' guide here: http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of now, the mlobs logger logs every single message sent to the logger. As there is no good way at the moment to use different logger configuration for different model, tentatively, we will be adding a default sampling rate that will apply to all models that enable mlobs logger.
Modifications
Add a 2% sampling rate to mlobs sink.
Tests
Checklist
Release Notes