Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Add missing request timestamp for mlobs logger #568

Merged
merged 1 commit into from
Apr 3, 2024
Merged

bug: Add missing request timestamp for mlobs logger #568

merged 1 commit into from
Apr 3, 2024

Conversation

khorshuheng
Copy link
Collaborator

Description

The current mlobs logger does not populate the request timestamp, which result in error when writing to the sink.

Modifications

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes

@khorshuheng khorshuheng added the bug Something isn't working label Apr 3, 2024
@khorshuheng khorshuheng self-assigned this Apr 3, 2024
@khorshuheng khorshuheng merged commit 47b1ee6 into main Apr 3, 2024
36 checks passed
@khorshuheng khorshuheng deleted the fix-request-timestamp branch April 3, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariefrahmansyah ariefrahmansyah ariefrahmansyah approved these changes

@leonlnj leonlnj Awaiting requested review from leonlnj

@deadlycoconuts deadlycoconuts Awaiting requested review from deadlycoconuts

Assignees

@khorshuheng khorshuheng

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khorshuheng @ariefrahmansyah