bug: skip requirement comparison for pip reqs that is not a package #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorshuheng
force-pushed
the
skip-non-req-pip
branch
3 times, most recently
from
2d89f9b to
16e8395
Compare
leonlnj
reviewed
Apr 8, 2024
khorshuheng
force-pushed
the
skip-non-req-pip
branch
from
16e8395 to
6b6eb84
Compare
khorshuheng
force-pushed
the
skip-non-req-pip
branch
from
6b6eb84 to
8ddb657
Compare
khorshuheng
added a commit
that referenced
this pull request
Apr 16, 2024
…570) <!-- Thanks for sending a pull request! Here are some tips for you: 1. Run unit tests and ensure that they are passing 2. If your change introduces any API changes, make sure to update the e2e tests 3. Make sure documentation is updated for your PR! --> # Description <!-- Briefly describe the motivation for the change. Please include illustrations where appropriate. --> While the SDK is processing the conda env, and additional merlin dependencies are required, such as merlin-pyfunc-server, the SDK will check the existing conda env to verify if the dependency is already present. If not, the additional requirement will be appended as part of the dependencies. Unfortunately, this workflow assuems that every line under the `pip` configurations is a python package, which is not necessarily the case. For example, the user might specify trusted host or repository under the pip section. # Modifications <!-- Summarize the key code changes. --> Skip comparing pip requirements that is not a package while attempting to check if extra merlin dependencies are present in the conda.yaml file. # Tests <!-- Besides the existing / updated automated tests, what specific scenarios should be tested? Consider the backward compatibility of the changes, whether corner cases are covered, etc. Please describe the tests and check the ones that have been completed. Eg: - [x] Deploying new and existing standard models - [ ] Deploying PyFunc models --> # Checklist - [ ] Added PR label - [ ] Added unit test, integration, and/or e2e tests - [ ] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduces API changes # Release Notes <!-- Does this PR introduce a user-facing change? If no, just write "NONE" in the release-note block below. If yes, a release note is required. Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information about release notes, see kubernetes' guide here: http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While the SDK is processing the conda env, and additional merlin dependencies are required, such as merlin-pyfunc-server, the SDK will check the existing conda env to verify if the dependency is already present. If not, the additional requirement will be appended as part of the dependencies.
Unfortunately, this workflow assuems that every line under the
pipconfigurations is a python package, which is not necessarily the case. For example, the user might specify trusted host or repository under the pip section.Modifications
Skip comparing pip requirements that is not a package while attempting to check if extra merlin dependencies are present in the conda.yaml file.
Tests
Checklist
Release Notes