Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): Update pyfunc server and batch predictor default version #618

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

deadlycoconuts
Copy link
Contributor

@deadlycoconuts deadlycoconuts commented Nov 18, 2024

Description

This PR is the third part (3 out of 3) of a series of PRs to update the version of Mlflow used by Merlin (to 1.26.1*). These changes are:

  1. Update the version of Mlflow used in the Merlin SDK and publish it to PyPI
  2. Update
    • the Merlin pyfunc server and batch predictor to use the updated Merlin SDK version released in step 1 and publish them to PyPI
    • the Merlin API server to ensure that requests sent to Mlflow reflect the update API endpoint contracts
    • the Mlflow image so that it's built using version 1.26.1
  3. Update the default pyfunc server and batch predictor version in the Merlin SDK and publish its new version to PyPI

Since the pyfunc server and batch predictor versions have already been updated in the PR #617, we need to ensure that the SDK is able to use these newly released versions by default.

Modifications

  • python/sdk/merlin/model.py - Update the version bounds of the default pyfunc server and batch predictor version in the SDK

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes

NONE

@deadlycoconuts deadlycoconuts added the maintenance Dependency updates and other chores label Nov 18, 2024
@deadlycoconuts deadlycoconuts self-assigned this Nov 18, 2024
@deadlycoconuts deadlycoconuts marked this pull request as ready for review November 18, 2024 07:27
Copy link
Contributor

@tiopramayudi tiopramayudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @deadlycoconuts

@deadlycoconuts
Copy link
Contributor Author

Thanks for the quick review! Yeah in the future maybe we need to relook at the bumping of versions manually. I honestly can't think of any reason why we shouldn't bump this automatically the more I think about it 🤔

@deadlycoconuts deadlycoconuts merged commit 2b0b062 into main Nov 18, 2024
35 checks passed
@deadlycoconuts deadlycoconuts deleted the update_pyfunc_server_batch_predictor_ver branch November 18, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Dependency updates and other chores
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants