Make Treatment Service max goroutines configurable and add profiling …

…handler (#15) * Add profiler to Treatment Service handler * Make max goroutines configurable Co-authored-by: Krithika Sundararajan <krithika.sundararajan@go-jek.com>
caraml-dev · Jul 6, 2022 · 95d5624 · 95d5624
1 parent 158271c
commit 95d5624
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/treatment-service/config/config.go b/treatment-service/config/config.go
@@ -71,6 +71,7 @@ type SwaggerConfig struct {
 // DeploymentConfig captures the config related to the deployment of Treatment Service
 type DeploymentConfig struct {
 	EnvironmentType string `default:"local"`
+	MaxGoRoutines   int    `default:"100"`
 }
 
 type MetricSinkKind = string

diff --git a/treatment-service/config/config_test.go b/treatment-service/config/config_test.go
@@ -26,6 +26,7 @@ func TestDefaultConfigs(t *testing.T) {
 		},
 		DeploymentConfig: DeploymentConfig{
 			EnvironmentType: "local",
+			MaxGoRoutines:   100,
 		},
 		AssignedTreatmentLogger: AssignedTreatmentLoggerConfig{
 			Kind:                 "",
@@ -80,7 +81,7 @@ func TestLoadMultipleConfigs(t *testing.T) {
 			URL:                  "localhost:3000/v1",
 			AuthorizationEnabled: true,
 		},
-		DeploymentConfig: DeploymentConfig{EnvironmentType: "dev"},
+		DeploymentConfig: DeploymentConfig{EnvironmentType: "dev", MaxGoRoutines: 200},
 		AssignedTreatmentLogger: AssignedTreatmentLoggerConfig{
 			Kind:                 "bq",
 			QueueLength:          1073741824,

diff --git a/treatment-service/controller/internal.go b/treatment-service/controller/internal.go
@@ -2,6 +2,7 @@ package controller
 
 import (
 	"net/http"
+	_ "net/http/pprof"
 
 	"github.com/heptiolabs/healthcheck"
 
@@ -17,11 +18,13 @@ type InternalController struct {
 
 func NewInternalController(ctx *appcontext.AppContext, cfg *config.Config) *InternalController {
 	healthCheckHandler := healthcheck.NewHandler()
-	healthCheckHandler.AddLivenessCheck("goroutine-threshold", healthcheck.GoroutineCountCheck(100))
+	healthCheckHandler.AddLivenessCheck("goroutine-threshold", healthcheck.GoroutineCountCheck(cfg.DeploymentConfig.MaxGoRoutines))
 
 	mux := http.NewServeMux()
 	mux.Handle("/health/", http.StripPrefix("/health", healthCheckHandler))
-	mux.Handle("/debug", NewDebugHandler(ctx, cfg))
+	mux.Handle("/debug/dump", NewCacheDumpHandler(ctx, cfg))
+	// For profiling. net/http/pprof will register itself to http.DefaultServeMux.
+	mux.Handle("/debug/pprof/", http.DefaultServeMux)
 	return &InternalController{Handler: mux, AppContext: ctx, Config: cfg}
 }
 
@@ -30,7 +33,7 @@ type debugHandler struct {
 	Config *config.Config
 }
 
-func NewDebugHandler(ctx *appcontext.AppContext, cfg *config.Config) http.Handler {
+func NewCacheDumpHandler(ctx *appcontext.AppContext, cfg *config.Config) http.Handler {
 	return &debugHandler{AppContext: ctx, Config: cfg}
 }
 

diff --git a/treatment-service/testdata/config2.yaml b/treatment-service/testdata/config2.yaml
@@ -1,5 +1,6 @@
 DeploymentConfig:
   EnvironmentType: dev
+  MaxGoRoutines: 200
 
 SentryConfig:
   Enabled: true