Skip to content

Commit

Permalink
Merge pull request #3901 from carbon-design-system/datetimepicker-fly…
Browse files Browse the repository at this point in the history
…out-footerissue

DateTimePicker FlyoutMenu Footer Button issue fixed
  • Loading branch information
abpaul1993 authored Dec 9, 2024
2 parents 0059baf + ec09096 commit 8fb1ad2
Show file tree
Hide file tree
Showing 5 changed files with 157 additions and 122 deletions.
16 changes: 8 additions & 8 deletions packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,15 @@
"dependencies": {
"@babel/plugin-transform-optional-chaining": "^7.24.7",
"@babel/runtime": "^7.25.6",
"@carbon/charts": "^1.22.0",
"@carbon/charts-react": "^1.22.0",
"@carbon/colors": "^11.23.1",
"@carbon/icons-react": "^11.52.0",
"@carbon/layout": "^11.23.1",
"@carbon/pictograms-react": "^11.63.1",
"@carbon/react": "^1.70.0",
"@carbon/charts": "^1.22.7",
"@carbon/charts-react": "^1.22.7",
"@carbon/colors": "^11.28.0",
"@carbon/icons-react": "^11.53.0",
"@carbon/layout": "^11.28.0",
"@carbon/pictograms-react": "^11.69.0",
"@carbon/react": "^1.72.0",
"@carbon/telemetry": "^0.1.0",
"@carbon/themes": "^11.42.0",
"@carbon/themes": "^11.43.0",
"@codemirror/lang-css": "^6.3.0",
"@codemirror/lang-javascript": "^6.2.2",
"@codemirror/lang-json": "^6.0.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,6 @@ const DateTimePicker = ({
}}
testId={`${testId}-datepicker-flyout`}
direction={direction}
customFooter={() => {}}
tooltipFocusTrap={false}
renderInPortal={renderInPortal}
useAutoPositioning={false}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,6 @@ const DateTimePicker = ({
}}
testId={`${testId}-datepicker-flyout`}
direction={direction}
customFooter={() => {}}
tooltipFocusTrap={false}
renderInPortal={renderInPortal}
useAutoPositioning={false}
Expand Down
2 changes: 2 additions & 0 deletions packages/react/src/components/FlyoutMenu/FlyoutMenu.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,8 @@ const FlyoutMenu = ({

const Footer = CustomFooter ? (
<CustomFooter setIsOpen={setIsOpen} isOpen={isControlledOpen} />
) : testId?.endsWith('-datepicker-flyout') === true ? (
''
) : (
<DefaultFooter setIsOpen={setIsOpen} onCancel={onCancel} onApply={onApply} i18n={i18n} />
);
Expand Down
Loading

0 comments on commit 8fb1ad2

Please sign in to comment.