-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs--guidelines-spacing v2 and releases #1752
Conversation
…-for-ibm-dotcom-website into Docs--content-block-v2
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
…rbon-design-system/carbon-for-ibm-dotcom-website into Docs--guidelines-spacing
…-for-ibm-dotcom-website into Docs--guidelines-spacing
Deploy preview created: Built with commit: 268239f0f7a2c8e3eb9526a17de04961a4deb62d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RichKummer A few copy fixes!
Let's have @jeanservaas read it too to see if it reads well to someone who is less lost in the sauce / deep in the weeds of knowledge
*also I didn't mean to approve yet, we should fix some of these items below!
<Row> | ||
<Column colLg={8}> | ||
|
||
![A card component with internal spacing highlighted](../../images/guidelines/spacing/guidelines-spacing-spacing-concepts-01.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge deal, but is the arrow purple on the card here? If it's an old image we don't have to update
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RichKummer Looks great! Just a few suggestions.
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
…design-system/carbon-for-ibm-dotcom-website into Docs--guidelines-spacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @RichKummer let's merge it in!
Related Ticket(s)
#1644
Description
Update spacing page for v2
Changelog
New
Changed
Removed