Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs--guidelines-spacing v2 and releases #1752

Merged
merged 33 commits into from
Feb 19, 2024
Merged

Conversation

RichKummer
Copy link
Contributor

@RichKummer RichKummer commented Dec 29, 2023

Related Ticket(s)

#1644

Description

Update spacing page for v2

Changelog

New

  • New content
  • New images
  • New content component table

Changed

  • Updated v2 language
  • Moved spacing tables to corresponding content component pages
  • Spacing block color
  • FAQ
  • Support section has been changed to Feedback for consistency

Removed

  • Old images

RichKummer and others added 14 commits December 20, 2023 15:53
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 29, 2023

@RichKummer RichKummer self-assigned this Jan 3, 2024
@RichKummer RichKummer marked this pull request as ready for review January 3, 2024 19:41
@RichKummer RichKummer requested a review from a team as a code owner January 3, 2024 19:41
@RichKummer RichKummer requested review from kennylam, emyarod and oliviaflory and removed request for a team January 3, 2024 19:41
oliviaflory
oliviaflory previously approved these changes Jan 3, 2024
Copy link
Contributor

@oliviaflory oliviaflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichKummer A few copy fixes!

Let's have @jeanservaas read it too to see if it reads well to someone who is less lost in the sauce / deep in the weeds of knowledge

*also I didn't mean to approve yet, we should fix some of these items below!

src/pages/guidelines/spacing.mdx Outdated Show resolved Hide resolved
src/pages/guidelines/spacing.mdx Outdated Show resolved Hide resolved
<Row>
<Column colLg={8}>

![A card component with internal spacing highlighted](../../images/guidelines/spacing/guidelines-spacing-spacing-concepts-01.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge deal, but is the arrow purple on the card here? If it's an old image we don't have to update

src/pages/guidelines/spacing.mdx Outdated Show resolved Hide resolved
src/pages/guidelines/spacing.mdx Outdated Show resolved Hide resolved
@oliviaflory oliviaflory self-requested a review January 3, 2024 20:29
RichKummer and others added 2 commits January 3, 2024 15:40
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
RichKummer and others added 6 commits January 3, 2024 15:42
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
@oliviaflory oliviaflory dismissed their stale review January 4, 2024 14:45

not yet approved

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichKummer Looks great! Just a few suggestions.

src/pages/components/content-block.mdx Outdated Show resolved Hide resolved
src/pages/about-carbon-for-ibm.com/releases.mdx Outdated Show resolved Hide resolved
src/pages/about-carbon-for-ibm.com/releases.mdx Outdated Show resolved Hide resolved
RichKummer and others added 5 commits January 25, 2024 09:29
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
@RichKummer RichKummer changed the title Docs--guidelines-spacing v2 Docs--guidelines-spacing v2 and releases Jan 25, 2024
Copy link
Contributor

@oliviaflory oliviaflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @RichKummer let's merge it in!

@oliviaflory oliviaflory enabled auto-merge (squash) February 19, 2024 18:42
@oliviaflory oliviaflory merged commit 274b431 into main Feb 19, 2024
6 checks passed
@oliviaflory oliviaflory deleted the Docs--guidelines-spacing branch February 19, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants