-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: library rewrite #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonym
force-pushed
the
rewrite-preprocessor
branch
18 times, most recently
from
March 17, 2024 20:55
8e36b7b
to
e85c028
Compare
metonym
force-pushed
the
rewrite-preprocessor
branch
from
March 17, 2024 20:57
e85c028
to
c24d2fe
Compare
What's blocking this PR is that some Carbon components that employ custom styling (e.g., |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50, closes #44, closes #46, closes #53, closes #52, closes #48, closes #47, closes #46, closes #40, closes #26, closes #24, closes #19, closes #18, closes #17, closes #28
Breaking Changes
optimizeImports
optimizeImports
: drop support forcarbon-icons-svelte
version 10,carbon-pictograms-svelte
version 10optimizeCss
plugin from scratch; it's now offered as a Vite/Rollup/Webpack plugin.carbon-components-svelte@0.85.0
or greater is requiredoptimizeImports
Notes: for best DX, also instruct
Vite
tooptimizeDeps.ignore
optimizeCss
Steps:
The potential for false positives is too high (relying on any and all selectors). Instead, focus on class names as this is much more defensive (e.g.,
.bx--
). The goal is to still remove the bulk of unused.bx--
selectors without needing to stress about false positives.plugin.transform
hook.generateBundle
hook, read in all generated.css
files..bx--
selectors that are not included in the map.