Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update carbon and gatsby-theme-carbon deps #3660

Merged
merged 1 commit into from
Jul 27, 2023
Merged

chore: update carbon and gatsby-theme-carbon deps #3660

merged 1 commit into from
Jul 27, 2023

Conversation

alisonjoseph
Copy link
Member

  • Check switcher icon alignment
  • Check Color tokens page
  • Check that grid is rendering correctly

@alisonjoseph alisonjoseph requested review from a team as code owners July 25, 2023 18:56
@vercel
Copy link

vercel bot commented Jul 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 7:13pm

guidari
guidari approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tw15egan
tw15egan approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@alisonjoseph alisonjoseph self-assigned this Jul 27, 2023
@alisonjoseph alisonjoseph merged commit f14e22d into carbon-design-system:main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidari guidari guidari approved these changes

@tw15egan tw15egan tw15egan approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones was automatically assigned from carbon-design-system/developers-system

@thyhmdo thyhmdo Awaiting requested review from thyhmdo thyhmdo is a code owner automatically assigned from carbon-design-system/design

Assignees

@alisonjoseph alisonjoseph

Labels
status: one more review 👀 status: ready for review 👀 status: visual review 🔍
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alisonjoseph @tw15egan @guidari