Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage.mdx #4345

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Update usage.mdx #4345

merged 6 commits into from
Nov 13, 2024

Conversation

scanlana
Copy link
Contributor

Updated content as outlined in this issue:
#4234

These content updates are part of the work of the UI content design guild.

Closes #

{{short description}}

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 4:41pm

Copy link
Contributor

github-actions bot commented Oct 31, 2024

DCO Assistant Lite bot All contributors have signed the DCO.

src/pages/components/modal/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/modal/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/modal/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/modal/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/modal/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/modal/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/modal/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/modal/usage.mdx Outdated Show resolved Hide resolved
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it looks good now! Thanks for making those updates and answering my questions.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the updates are ready then it looks you just need to run yarn format in order to pass the CI check!

@aagonzales
Copy link
Member

@emyarod I'm not sure they know how to do that through the CLI. I think they did these edits through the GitHub GUI. I tried pulling the branch down myself to do it but ran into an error. Could you help with this?

scanlana and others added 6 commits November 13, 2024 10:33
Updated content as outlined in this issue:
carbon-design-system#4234
Fixing my overzealous application of IBM Style :)

Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Addressing comments from the pull request.
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be good to go now, just need @scanlana to sign the DCO by commenting I have read the DCO document and I hereby sign the DCO. !

@scanlana
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@kodiakhq kodiakhq bot merged commit 18d09a5 into carbon-design-system:main Nov 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants