Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): new AI label icon #17738

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

conradennis
Copy link
Contributor

Submitting a new AI label icon per the request of @aagonzales all updates and additions approved by BXD

Note: we may want to restrict the download option for this icon. Anna can follow up on that conversation.

1 new icon

updated categories.yml with addition
updated icons.yml with addition

Changelog

New

  • 32/ai-label.svg

Submitting a new AI label icon per the request of @aagonzales
all updates and additions approved by BXD

Note: we may want to restrict the download option for this icon. Anna can follow up on that conversation.

1 new icon

updated categories.yml with addition
updated icons.yml with addition
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4da45a6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/670d685519890f0008b5d972
😎 Deploy Preview https://deploy-preview-17738--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 4da45a6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/670d6855e3127800087dff02
😎 Deploy Preview https://deploy-preview-17738--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - unsure what you mean about restricting the download of the icon, once we add it in anyone will be able to access it.

@alisonjoseph alisonjoseph requested a review from a team as a code owner October 14, 2024 18:52
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.29%. Comparing base (4a7d935) to head (4da45a6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17738   +/-   ##
=======================================
  Coverage   79.29%   79.29%           
=======================================
  Files         406      406           
  Lines       14023    14023           
  Branches     4386     4386           
=======================================
  Hits        11120    11120           
- Misses       2737     2738    +1     
+ Partials      166      165    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aagonzales
Copy link
Member

aagonzales commented Oct 14, 2024

@alisonjoseph Adam Cutler wants to be able to see the AI Label icon along-side the other AI icons in the icon library but ideally we only want people using the AI Label component and not this icon svg.

Mike's original proposal for circumnavigating this would be to replace the "Download" actions with a "launch" action to view the component in Storybook instead.

image

@aagonzales
Copy link
Member

Figuring out the website issue doesn't need to block adding the icon to the pack though. So I think we're good to merge this in.

@kennylam kennylam added this pull request to the merge queue Oct 14, 2024
Merged via the queue into carbon-design-system:main with commit 7fda14b Oct 14, 2024
36 checks passed
@alisonjoseph
Copy link
Member

@aagonzales oh ok, we can do something like that if you want to create an issue. Also looking at your screen shot I swear those hover states for download icons used to be square.

@aagonzales
Copy link
Member

OK I've opened an issue: carbon-design-system/carbon-website#4323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants