-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): new AI label icon #17738
feat(icons): new AI label icon #17738
Conversation
Submitting a new AI label icon per the request of @aagonzales all updates and additions approved by BXD Note: we may want to restrict the download option for this icon. Anna can follow up on that conversation. 1 new icon updated categories.yml with addition updated icons.yml with addition
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - unsure what you mean about restricting the download of the icon, once we add it in anyone will be able to access it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17738 +/- ##
=======================================
Coverage 79.29% 79.29%
=======================================
Files 406 406
Lines 14023 14023
Branches 4386 4386
=======================================
Hits 11120 11120
- Misses 2737 2738 +1
+ Partials 166 165 -1 ☔ View full report in Codecov by Sentry. |
@alisonjoseph Adam Cutler wants to be able to see the AI Label icon along-side the other AI icons in the icon library but ideally we only want people using the AI Label component and not this icon svg. Mike's original proposal for circumnavigating this would be to replace the "Download" actions with a "launch" action to view the component in Storybook instead. |
Figuring out the website issue doesn't need to block adding the icon to the pack though. So I think we're good to merge this in. |
7fda14b
@aagonzales oh ok, we can do something like that if you want to create an issue. Also looking at your screen shot I swear those hover states for download icons used to be square. |
OK I've opened an issue: carbon-design-system/carbon-website#4323 |
Submitting a new AI label icon per the request of @aagonzales all updates and additions approved by BXD
Note: we may want to restrict the download option for this icon. Anna can follow up on that conversation.
1 new icon
updated categories.yml with addition
updated icons.yml with addition
Changelog
New